[Win32] Fix potential memory leak in GC#drawImage #2499 #2500
+36
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 118 files ±0 118 suites ±0 10m 27s ⏱️ - 1m 32s For more details on these failures, see this check. Results for commit 0b489c7. ± Comparison against base commit 8c237c5. ♻️ This comment has been updated with latest results. |
fedejeanne
approved these changes
Sep 12, 2025
fedejeanne
force-pushed
the
issue-2499
branch
from
d41b364 to
641b13e
Compare
|
The test failure seems unrelated (it's in the Browser tests). Rebasing. |
fedejeanne
force-pushed
the
issue-2499
branch
from
641b13e to
6c2372b
Compare
When calling GC#drawImage(), an operation is created (like for every execution on GC) which stores the image to draw. Since the image may be disposed afterwards, a dispose listener is registered to the image, such that the image can be copied and maintained inside the operation in case of a disposal until that operation itself is disposed. The listener is currently not de-registered when disposing the GC and its operations, thus the GC operations (and thus also the containing GC) will still be referenced (as listeners from the image) until that image is disposed. Since images may be long living (or never be disposed at all), this can lead to a memory leak. This change removes the listener from the image upon disposal of a GC and its operations such that no memory can occur. Fixes eclipse-platform#2499
akoch-yatta
force-pushed
the
issue-2499
branch
from
6c2372b to
0b489c7
Compare
akoch-yatta
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
GC#drawImage(), an operation is created (like for every execution on GC) which stores the image to draw. Since the image may be disposed afterwards, a dispose listener is registered to the image, such that the image can be copied and maintained inside the operation in case of a disposal until that operation itself is disposed. The listener is currently not de-registered when disposing the GC and its operations, thus the GC operations (and thus also the containing GC) will still be referenced (as listeners from the image) until that image is disposed. Since images may be long living (or never be disposed at all), this can lead to a memory leak.This change removes the listener from the image upon disposal of a GC and its operations such that no memory can occur.
Fixes #2499